2026-05-28 22:06:15 -05:00
|
|
|
'use strict';
|
|
|
|
|
|
|
|
|
|
const { getSetting, setSetting } = require('../db/database');
|
|
|
|
|
|
2026-05-30 21:20:51 -05:00
|
|
|
const SYNC_DAYS_MAX = 45; // SimpleFIN Bridge hard limit — requests beyond this return an error
|
|
|
|
|
const SYNC_DAYS_EFFECTIVE = 44; // 1-day buffer so request latency never tips over the hard limit
|
|
|
|
|
const SYNC_DAYS_DEFAULT = 30; // routine sync window (initial seed always uses SYNC_DAYS_EFFECTIVE)
|
|
|
|
|
const SYNC_INTERVAL_DEFAULT = 4; // hours
|
2026-05-28 22:06:15 -05:00
|
|
|
|
|
|
|
|
function getBankSyncConfig() {
|
|
|
|
|
const dbValue = getSetting('bank_sync_enabled');
|
|
|
|
|
const envValue = process.env.BANK_SYNC_ENABLED;
|
|
|
|
|
|
|
|
|
|
let enabled;
|
|
|
|
|
if (dbValue !== null && dbValue !== undefined && dbValue !== '') {
|
|
|
|
|
enabled = dbValue === 'true';
|
|
|
|
|
} else if (envValue !== undefined && envValue !== '') {
|
|
|
|
|
enabled = envValue === 'true';
|
|
|
|
|
} else {
|
|
|
|
|
enabled = false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
const syncDaysDb = parseInt(getSetting('simplefin_sync_days') || '', 10);
|
|
|
|
|
const syncDaysEnv = parseInt(process.env.SIMPLEFIN_SYNC_DAYS || '', 10);
|
2026-05-29 02:23:19 -05:00
|
|
|
const rawSyncDays = Number.isFinite(syncDaysDb) && syncDaysDb > 0
|
2026-05-28 22:06:15 -05:00
|
|
|
? syncDaysDb
|
|
|
|
|
: Number.isFinite(syncDaysEnv) && syncDaysEnv > 0
|
|
|
|
|
? syncDaysEnv
|
|
|
|
|
: SYNC_DAYS_DEFAULT;
|
2026-05-29 02:51:30 -05:00
|
|
|
const syncDays = Math.min(rawSyncDays, SYNC_DAYS_EFFECTIVE);
|
2026-05-28 22:06:15 -05:00
|
|
|
|
feat: configurable sync interval, auto-match, encryption note, admin link, SimpleFIN hyperlink
#1 Sync interval in admin UI:
- bankSyncConfigService: reads simplefin_sync_interval_hours from settings
(DB-first, env fallback, default 4h), setSyncIntervalHours() with validation
- bankSyncWorker: live-updates interval from getBankSyncConfig() each tick
- routes/admin: PUT accepts enabled and sync_interval_hours independently
- BankSyncAdminCard: number input (0.5 step, 0.5-168 range), dirty-checks both
#3 Auto-match after background sync:
- matchSuggestionService: autoMatchForUser() auto-applies suggestions ≥80
score (exact amount + date ±1d + name signal), lazy-requires matchTransactionToBill
- bankSyncWorker: calls autoMatchForUser after each successful sync, own try/catch
#4 Encryption note in BankSyncAdminCard below worker status panel
Also: error handling, admin link in tracker sidebar, SimpleFIN bridge hyperlink
2026-05-29 00:28:50 -05:00
|
|
|
const intervalDb = parseFloat(getSetting('simplefin_sync_interval_hours') || '');
|
|
|
|
|
const intervalEnv = parseFloat(process.env.SIMPLEFIN_SYNC_INTERVAL_HOURS || '');
|
|
|
|
|
const syncIntervalHours = Number.isFinite(intervalDb) && intervalDb >= 0.5
|
|
|
|
|
? intervalDb
|
|
|
|
|
: Number.isFinite(intervalEnv) && intervalEnv >= 0.5
|
|
|
|
|
? intervalEnv
|
|
|
|
|
: SYNC_INTERVAL_DEFAULT;
|
|
|
|
|
|
2026-05-28 22:06:15 -05:00
|
|
|
return {
|
|
|
|
|
enabled,
|
|
|
|
|
sync_days: syncDays,
|
feat: configurable sync interval, auto-match, encryption note, admin link, SimpleFIN hyperlink
#1 Sync interval in admin UI:
- bankSyncConfigService: reads simplefin_sync_interval_hours from settings
(DB-first, env fallback, default 4h), setSyncIntervalHours() with validation
- bankSyncWorker: live-updates interval from getBankSyncConfig() each tick
- routes/admin: PUT accepts enabled and sync_interval_hours independently
- BankSyncAdminCard: number input (0.5 step, 0.5-168 range), dirty-checks both
#3 Auto-match after background sync:
- matchSuggestionService: autoMatchForUser() auto-applies suggestions ≥80
score (exact amount + date ±1d + name signal), lazy-requires matchTransactionToBill
- bankSyncWorker: calls autoMatchForUser after each successful sync, own try/catch
#4 Encryption note in BankSyncAdminCard below worker status panel
Also: error handling, admin link in tracker sidebar, SimpleFIN bridge hyperlink
2026-05-29 00:28:50 -05:00
|
|
|
sync_interval_hours: syncIntervalHours,
|
2026-05-28 22:06:15 -05:00
|
|
|
};
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
function setBankSyncEnabled(enabled) {
|
|
|
|
|
setSetting('bank_sync_enabled', enabled ? 'true' : 'false');
|
|
|
|
|
return getBankSyncConfig();
|
|
|
|
|
}
|
|
|
|
|
|
feat: configurable sync interval, auto-match, encryption note, admin link, SimpleFIN hyperlink
#1 Sync interval in admin UI:
- bankSyncConfigService: reads simplefin_sync_interval_hours from settings
(DB-first, env fallback, default 4h), setSyncIntervalHours() with validation
- bankSyncWorker: live-updates interval from getBankSyncConfig() each tick
- routes/admin: PUT accepts enabled and sync_interval_hours independently
- BankSyncAdminCard: number input (0.5 step, 0.5-168 range), dirty-checks both
#3 Auto-match after background sync:
- matchSuggestionService: autoMatchForUser() auto-applies suggestions ≥80
score (exact amount + date ±1d + name signal), lazy-requires matchTransactionToBill
- bankSyncWorker: calls autoMatchForUser after each successful sync, own try/catch
#4 Encryption note in BankSyncAdminCard below worker status panel
Also: error handling, admin link in tracker sidebar, SimpleFIN bridge hyperlink
2026-05-29 00:28:50 -05:00
|
|
|
function setSyncIntervalHours(hours) {
|
|
|
|
|
const n = parseFloat(hours);
|
|
|
|
|
if (!Number.isFinite(n) || n < 0.5 || n > 168) {
|
|
|
|
|
throw Object.assign(new Error('sync_interval_hours must be between 0.5 and 168'), { status: 400 });
|
|
|
|
|
}
|
|
|
|
|
setSetting('simplefin_sync_interval_hours', String(Math.round(n * 10) / 10));
|
|
|
|
|
return getBankSyncConfig();
|
|
|
|
|
}
|
|
|
|
|
|
2026-05-29 01:33:54 -05:00
|
|
|
function setSyncDays(days) {
|
|
|
|
|
const n = parseInt(days, 10);
|
2026-05-29 02:23:19 -05:00
|
|
|
if (!Number.isFinite(n) || n < 1 || n > SYNC_DAYS_MAX) {
|
|
|
|
|
throw Object.assign(new Error(`sync_days must be between 1 and ${SYNC_DAYS_MAX} (SimpleFIN Bridge hard limit)`), { status: 400 });
|
2026-05-29 01:33:54 -05:00
|
|
|
}
|
|
|
|
|
setSetting('simplefin_sync_days', String(n));
|
|
|
|
|
return getBankSyncConfig();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
module.exports = { getBankSyncConfig, setBankSyncEnabled, setSyncIntervalHours, setSyncDays };
|