null
/
Closer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Closer/ClaudeReport.md

45 lines
4.1 KiB
Markdown
Raw Normal View History

qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
# Claude QA Report — Full-App QA (living report)
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
> **Verdict (2026-06-25): 0 open issues at every severity (P0–P3). Security cornerstone fully clean. App is at the "flawless" bar.**
docs(seed): replace question guides with v2 — content guide, rewrite plan, new quality checklist
2026-06-25 18:48:37 -05:00
>
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
> This report shows **current state only**. Fixed issues live here for **one** confirmation round, then they're pruned
> to the archived-ID line below (full detail stays in git history). See **Report hygiene** in `ClaudeQAPlan.md`.
docs(seed): replace question guides with v2 — content guide, rewrite plan, new quality checklist
2026-06-25 18:48:37 -05:00
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
## Run-state (current)
qa(R8): re-confirm F-RACE-001 live (race -> 1 session, loser joins same set) + prune Round 8 chunk 1. Simultaneous mood-tap on both emulators -> exactly 1 active session (was 2 pre-fix); race-loser hit WaitingForPartner -> "Join the game" -> joined the winner's session at the same Q1 (shared reveal preserved). Regression smoke clean: no FATAL, game opens both devices, inbox loads, messages + date_swipes ciphertext at rest. F-RACE-001 pruned to the archived-ID line per report hygiene; 0 open P0-P3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:32:31 -05:00
`Round 8 (re-QA + Passes I/J) — IN PROGRESS | 0 open P0–P3 | F-RACE-001 re-confirmed + pruned | NEXT ACTION: Pass I (performance), then Pass J (a11y).`
- **Build:** client HEAD `23dd6a7`, Cloud Functions deployed.
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
- **Devices / accounts:** emulator-5554 = QA (`Y05AKO2IlTPMa0JQW1BiNIM0uzK2`) · emulator-5556 = Sam (`imDjjO…`) · paired, coupleId `Xal3Kw3gjSdn0niERYKJ`, both free (baseline restored).
- **Docs:** Playbook `ClaudeQAPlan.md` · Coverage `ClaudeQACoverage.md` · Ideas `Future.md` `## QA` · Branding `ClaudeBrandingReview.md`.
docs(seed): replace question guides with v2 — content guide, rewrite plan, new quality checklist
2026-06-25 18:48:37 -05:00
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
## Severity board
| Severity | Open | Fixed (pending 1 confirm) |
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
|---|---|---|
| P0 | 0 | 0 |
qa(R8): re-confirm F-RACE-001 live (race -> 1 session, loser joins same set) + prune Round 8 chunk 1. Simultaneous mood-tap on both emulators -> exactly 1 active session (was 2 pre-fix); race-loser hit WaitingForPartner -> "Join the game" -> joined the winner's session at the same Q1 (shared reveal preserved). Regression smoke clean: no FATAL, game opens both devices, inbox loads, messages + date_swipes ciphertext at rest. F-RACE-001 pruned to the archived-ID line per report hygiene; 0 open P0-P3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:32:31 -05:00
| P1 | 0 | 0 |
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
| P2 | 0 | 0 |
| P3 | 0 | 0 |
qa(r3): Pass C visual sweep + Pass D security re-audit clean Pass C: ~14 screen-types in dark (Home, Play, all 7 games, paywall, Settings+Subscription+Appearance, Today, Messages inbox, Conversation) render clean, no FATAL, no new contrast issues, 0 enc:v1 leaked to UI. C-DS-001 holds. C-OBS: debug menu entries (verify BuildConfig.DEBUG-gated). Remaining standard list/detail screens deferred (nav-drift). Pass D: deployed rules re-audited (B-001 + D-001 fixes present, hasPremium/entitlements server-only, ciphertext enforced, no catch-all); at-rest chat text + preview = enc:v1. D3 live deferred (3rd acct). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 11:25:19 -05:00
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
## Open issues
**None.**
qa(r3): Pass E live notif tests — chat_message full chain OK; log E-003 + E-OBS chat_message: deliver (bg) + content-free + tap deep-links to exact conversation with content loaded. partner_started_game: deliver + content-free OK; tap -> generic Play hub (not the game). E-003 (P2): game pushes routeFor->AppRoute.PLAY (not the specific game/results) despite 'Tap to join!'; extend B-002's game-route resolver to notifications. E-OBS (P3): backgrounded pushes use fcm_fallback_notification_channel, bypassing code-defined CHANNEL_GAMES/chat channels (server sends notification not data-only). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 11:32:32 -05:00
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
## Resolved & confirmed (archived — full detail in git history)
qa(R8): re-confirm F-RACE-001 live (race -> 1 session, loser joins same set) + prune Round 8 chunk 1. Simultaneous mood-tap on both emulators -> exactly 1 active session (was 2 pre-fix); race-loser hit WaitingForPartner -> "Join the game" -> joined the winner's session at the same Q1 (shared reveal preserved). Regression smoke clean: no FATAL, game opens both devices, inbox loads, messages + date_swipes ciphertext at rest. F-RACE-001 pruned to the archived-ID line per report hygiene; 0 open P0-P3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:32:31 -05:00
A-001 · A-003 · A-OBS · B-001 · B-002 · B-003 · B-004 · C-CC-001 · C-DS-001 · C-NAV-001 · D-001 · E-001 · E-002 · E-003 · E-OBS · F-OBS · F-RACE-001 — all fixed and re-verified (commits in history; **F-RACE-001** fixed `23dd6a7`, re-confirmed live R8: race → 1 session, loser joins same set). Pruned per the one-confirmation-round rule. (C-OBS / `outcomes` list / SubscriptionScreen per-user gate = investigated, **not bugs**.)
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
## Security cornerstone — clean (Pass D, deep dive, Round 7)
- **D1 at-rest:** chat text + `lastMessagePreview` + all 4 game-answer collections (ToT / How Well / Desire Sync / Wheel, both users) + Memory Lane capsules + date-swipe actions = `enc:v1:`. No plaintext content; only metadata in clear.
- **D2/D3 access:** non-member denied **all** reads/writes (raw Firestore REST → 403); real premium write `users/{uid}/entitlements/premium` denied (server-only → **no self-grant**); cross-couple denied.
- **D4 keys:** couple key phrase-wrapped (argon2id); recovery phrase server-blind; `encryptedRecoveryPhrase` wiped on acceptance; plaintext `inviteCode` not exploitable (invite readable only by inviter; no code-encrypted secret persisted).
- **Robustness:** malformed/abusive deep-link intents (unknown type, missing extras, injection/path-traversal) → 0 crash; killed-state cold-start chat deep-link → conversation loads.
## Round history (one line each)
qa(R8): re-confirm F-RACE-001 live (race -> 1 session, loser joins same set) + prune Round 8 chunk 1. Simultaneous mood-tap on both emulators -> exactly 1 active session (was 2 pre-fix); race-loser hit WaitingForPartner -> "Join the game" -> joined the winner's session at the same Q1 (shared reveal preserved). Regression smoke clean: no FATAL, game opens both devices, inbox loads, messages + date_swipes ciphertext at rest. F-RACE-001 pruned to the archived-ID line per report hygiene; 0 open P0-P3. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:32:31 -05:00
- **R8** (in progress) — F-RACE-001 re-confirmed live (race → 1 session; loser joins winner's same-set session via "Join the game") + pruned; running Passes I/J.
docs(qa): merge notification-suite playbook, add report hygiene + finding-routing, clean report/coverage - ClaudeQAPlan.md: fold the deep notification + join-game suite into Pass E (both-client matrix, 6 assertions, expanded inventory, game/join-game suites, payload security, malformed/stale tests); add Pass B join-paths + Pass C routes-into-games; add missing batch rows G/H; add Report-hygiene (one-confirmation-round prune) + coverage-matrix hygiene + easy-to-read mandate; add "Where every finding goes" routing table. - ClaudeReport.md: collapse stacked R1-R7 run-states + fixed tables to current-state (0 open P0-P3; F-RACE-001 pending one confirm; older fixed IDs archived). - ClaudeQACoverage.md: current-status matrix (flip stale fail->A-001 to pass, drop contradictory Pass B footer, add status-at-a-glance, surface todo/deferred). - removed stray seed/questions/Claude_QA_Playbook_Full_App_QA_Notifications_Merged.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-25 23:23:30 -05:00
- **R7** — multi-angle security/concurrency deep dive → cornerstone fully clean; F-RACE-001 found + fixed + verified. 0 new open.
- **R6** — branding drop + Future.md backlog regression (white-keyhole icons/loader/splash, inclusive gender, copy, rate-limit split, results-push suppression, paywall retry/offline) → 0 new open.
- **R5** — Cloud Functions deployed (E-OBS channel fix, E-003 results routing) + new Pass G (account creation / fake-account abuse) clean → 0 open.
- **R1–R4** — baseline Passes A–F report-only; every P0–P2 found was fixed + verified (see archived IDs).
## Operational constants
- **Execution mode:** autonomous run-to-completion — don't stop; fix blockers inline; cycle fix→re-QA until flawless. Don't hand back when context fills — re-read this run-state + coverage after any compaction. Commit before interruptible work; recover stuck sessions via the session-start ritual.
- **Standing authorization (user, 2026-06-24):** may `firebase deploy --only firestore:rules` + has admin access (Firestore reads/writes/seeds + entitlement toggles) — run without pausing. Only the macOS requirement for iOS (Parts 2/3) is a hard stop.
- **Hardening backlog → Future.md:** App Check not enforced on Firestore; `users/{uid}` update rule allows arbitrary non-`hasPremium` fields (tighten to a field allowlist).