null
/
Closer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Closer/ClaudeReport.md

43 lines
2.3 KiB
Markdown
Raw Normal View History

qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
# Claude QA Report — Full-App QA (living report)
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
> **RUN-STATE: Round 1 | Pass B (games lifecycle) | NEXT ACTION: drive each game start→finish on both devices, log issues.** (Pass A done: A-001 P1.)
> Playbook: `ClaudeQAPlan.md`. Coverage matrix: `ClaudeQACoverage.md`. Report-only during passes (no fixes until the fix phase).
> Devices: emulator-5554 (QA=`Y05AKO`) + emulator-5556 (Sam=`imDjjO`), paired (coupleId `Xal3Kw3gjSdn0niERYKJ`). Build == HEAD `64f0a7e`.
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
_(Prior games/notifications QA from 2026-06-24 was completed + verified; superseded by this full-app effort.)_
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
---
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
## Severity summary (Round 1)
| Severity | Open | Fixed |
|---|---|---|
| P0 | 0 | 0 |
| P1 | 1 | 0 |
| P2 | 0 | 0 |
| P3 | 0 | 0 |
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
feat(notifications): FCM token registration on auth, Android 13 permission request, in-app chat bubble overlay, game results notification copy - MainActivity: request POST_NOTIFICATIONS on TIRAMISU+, register FCM token when user signs in - AppMessagingService: foreground chat messages show draggable bubble instead of OS notification - MessageBubbleController/Overlay: new in-app chat-head that drifts over all screens, tap to open - PartnerNotificationManager: GAME_RESULTS_READY type with proper copy, partner_finished_game maps to it - onGameSessionUpdate: notify BOTH partners on completion (not just the non-starter), fix starter name in notification
2026-06-24 11:47:49 -05:00
---
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
## Pass A — Couple-shared premium ✅ pass complete
**Target:** if either partner is premium, all premium features unlock for both.
**Result:** only chat is couple-shared. Every other feature gate is per-user → a free user whose partner paid stays locked.
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
| ID | Area | Screen/Route | Severity | Description | Repro | Status |
|---|---|---|---|---|---|---|
| A-001 | Premium gating | PlayHubViewModel, DesireSyncScreen, MemoryLaneScreen, ConnectionChallengesScreen, QuestionPackLibraryViewModel, wheel CategoryPicker/SpinWheel/WheelHistory(VMs) | **P1** | These gate on per-user `EntitlementChecker.isPremium()` instead of couple-shared `CouplePremiumChecker.coupleHasPremium(partnerId)`. A free partner of a premium user stays locked — violates couple-shared requirement. | Set Sam premium, QA free → QA Play hub still shows 🔒 Premium on Desire Sync + Memory Lane (confirmed live). Code: only `ConversationViewModel` uses CouplePremiumChecker. | Open |
| A-002 | Premium (control) | ConversationViewModel (chat) | — | **Working correctly** (couple-shared) — kept as the reference pattern for the A-001 fix. | Verified prior round: partner-premium unlocks chat media/reactions for the free partner. | OK |
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
**Note (by-design, not a bug):** `SubscriptionScreen` uses per-user `isPremium()` — correct, it reflects the user's *own* subscription/account state, not a feature gate.
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
## Pass B — Games lifecycle
_not started_
## Pass C — Visual (light + dark)
_not started_
fix(reveal): partner option labels, release-key read rules, thread status uppercase, session id propagation, notification deep links, and re-open guard - Firestore rules: partner can read user doc (name/photo), sender can read own release key - QuestionThread: status stored UPPERCASE to match rules (lowercase broke discussion) - GameSessionManager: propagate auto-generated session id (empty id crashed game start) - AnswerReveal: decrypt partner's selectedOptionTexts from option IDs (showed raw ids) - FirestoreAnswerDataSource: tolerate Timestamp/Date in updatedAt (serverTimestamp crash) - FirestoreReleaseKeyDataSource: tolerate PERMISSION_DENIED on existence check (sender can't read) - QuestionThreadRepository: runCatching status update (legacy lowercase status blocked submit) - PartnerNotificationManager: suppress notification for active thread, deep link to thread - ActiveThreadMonitor: new class tracks which thread user is reading (suppresses own notifs) - DesireSync/HowWell/ThisOrThat: re-open guard skips INTRO if already answered; blank sessionId guard - AppNavigation: deep link pattern for chat notification
2026-06-24 10:02:54 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
## Pass D — Security & Encryption
_not started_
feat(notifications): FCM token registration on auth, Android 13 permission request, in-app chat bubble overlay, game results notification copy - MainActivity: request POST_NOTIFICATIONS on TIRAMISU+, register FCM token when user signs in - AppMessagingService: foreground chat messages show draggable bubble instead of OS notification - MessageBubbleController/Overlay: new in-app chat-head that drifts over all screens, tap to open - PartnerNotificationManager: GAME_RESULTS_READY type with proper copy, partner_finished_game maps to it - onGameSessionUpdate: notify BOTH partners on completion (not just the non-starter), fix starter name in notification
2026-06-24 11:47:49 -05:00
qa(round1): Pass A complete — couple-shared premium gap (A-001, P1) Only chat uses CouplePremiumChecker; all other gates are per-user → a free partner of a premium user stays locked. Confirmed live (Sam premium, QA still locked on Desire Sync + Memory Lane). Report-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-24 19:59:04 -05:00
## Pass E — Notifications
_not started_