doc-triggers cannot see root documents, so their headers are decorative #22
Labels
No Label
P0
P1
P2
release-blocker
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: null/Project-Template#22
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
doc-triggers.pycollects governing documents with:So it reads nothing at the repository root.
README.md,project-readme-template.mdand the two newSTART-HERE-*.mddocuments all carryStatus,GovernsandReview triggerlines that nothing ever reads. Changing a file those documents govern fires nothing, and the output says "No document's Governs matched these paths" — which is true of the tool and false of the repository.Demonstrated after correcting
README.md's ownGoverns:line, which saidProjects/Template/**— accurate while this was a folder insideProjects/, and matching nothing once it became a repository root. It now names the three root documents it actually makes claims about, and still fires nothing, because the tool cannot see it.This is the same family as #21 and worth counting as one. There, three documents were classified as path-governing and given a glob no file could match; here, four documents are excluded from collection altogether. Both are a check that is silent about the thing it was pointed at, and in both cases the screen said something reassuring instead.
Root documents genuinely do govern paths.
README.mddescribes the two start-here documents and links to them; when one is renamed or rewritten, README is exactly the document that should be revisited, and today nothing says so.Fix: collect from the root as well —
ROOT.glob("*.md")alongside the existingDOCS.rglob("*.md"), non-recursive at the root so a vendored copy or a stray directory of notes cannot enrol itself. Everything downstream already handles a document path outsidedocs/.Worth checking while in there whether anything else assumes documents live only under
docs/; the same assumption in the conformance reader is what excluded these files fromdoc-claimsuntil they were staged.Handing over rather than taking it, since
doc-triggers.pyhas been rewritten twice today and two sessions in one file is the collisioncommit-mine.shexists to prevent.Verify: touching START-HERE-New-Project.md fires README.md, and touching a file under docs/ still fires exactly what it fires today.